8000 Skip some uses of packaging's PEP440 version for non-Python versions. by anntzer · Pull Request #21639 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Skip some uses of packaging's PEP440 version for non-Python versions. #21639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2021
Merged

Skip some uses of packaging's PEP440 version for non-Python versions. #21639

merged 1 commit into from
Nov 15, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 15, 2021

Version numbers from non-Python packages don't have to follow PEP440,
and there are at least a few cases where we can check for string
equality (when we don't need ordering) or rely on the library's own
version parsing (qt).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Skip some uses of packaging's PEP440 version for non-Python versions.
0399682 
Version numbers from non-Python packages don't have to follow PEP440,
and there are at least a few cases where we can check for string
equality (when we don't need ordering) or rely on the library's own
version parsing (qt).
@anntzer anntzer added this to the v3.6.0 milestone Nov 15, 2021
@QuLogic QuLogic merged commit 4a44cb2 into matplotlib:main Nov 15, 2021
@anntzer anntzer deleted the pv branch November 15, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic
0