Do not use space in directive calling. #21534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is non standard, and does not work with all rst parsers. And those are the only few while there is approximatively 1200 directive that don't use space in the codebase
anntzer
approved these changes
Nov 3, 2021
anntzer
reviewed
Nov 3, 2021
lib/matplotlib/axes/_base.py
Outdated
| @@ -4215,7 +4215,7 @@ def set_navigate_mode(self, b): | |||
| """ | |||
| Set the navigation toolbar button status. | |||
|
|
|||
| .. warning :: | |||
| .. warning:: | |||
| this is not a user-API function. | |||
There was a problem hiding this comment.
can you fix the capitalization here while you're at it?
Carreau
commented
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is non standard, and does not work with all rst parsers.
And those are the only few while there is approximatively 1200 directive
that don't use space in the codebase
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).