8000 FIX: spanning subfigures by jklymak · Pull Request #21481 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: spanning subfigures #21481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 1 commit into from
Oct 30, 2021
Merged

FIX: spanning subfigures #21481

QuLogic merged 1 commit into from
Oct 30, 2021

Conversation

@jklymak
Copy link
Member
@jklymak jklymak commented Oct 28, 2021 •
edited
Loading

PR Summary

Closes #21480

In that issue, gridspec indexing with open slices fails with constrained_layout for subfigures...

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Oct 28, 2021
@jklymak jklymak added this to the v3.5.1 milestone Oct 28, 2021
QuLogic
QuLogic reviewed Oct 28, 2021
View reviewed changes
@QuLogic
Copy link
Member
QuLogic commented Oct 29, 2021

Did you mean to force push something? Seems like there are double commits.

@jklymak jklymak force-pushed the fix-arb-gs-subfigure branch from 060a397 to 9793992 Compare October 30, 2021 05:33
@jklymak
Copy link
Member Author
jklymak commented Oct 30, 2021

squashed!

@QuLogic QuLogic merged commit b09aad2 into matplotlib:main Oct 30, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 30, 2021
@QuLogic @meeseeksmachine
Backport PR matplotlib#21481: FIX: spanning subfigures
3e5a572
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 30, 2021
Merged
@QuLogic QuLogic modified the milestones: v3.5.1, v3.5.0 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

topic: geometry manager LayoutEngine, Constrained layout, Tight layout

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Subfigure breaks for some Gridspec slices when using constrained_layout

3 participants

@jklymak @QuLogic @tacaswell
0