8000 Also exclude pyparsing 3.0.0 in setup.py. by anntzer · Pull Request #21446 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Also exclude pyparsing 3.0.0 in setup.py. #21446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2021
Merged

Also exclude pyparsing 3.0.0 in setup.py. #21446

merged 1 commit into from
Oct 24, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 24, 2021

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak
jklymak approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops!

@timhoffm
Copy link
Member

The other pins use <3 not !=3. Is this a bug in pyparsing or an API change we have to adapt to?

@jklymak
Copy link
Member
jklymak commented Oct 24, 2021

I did less than 3.0.0 pending investigation to get CI to work. I'm not sure what the permanent solution is.

@dstansby
Copy link
Member

Yeah, I think < is probably preferred here.

@anntzer
Copy link
Contributor Author
anntzer commented Oct 24, 2021

< it is.

@timhoffm
Copy link
Member

Anybody can merge after CI pass.

@jklymak jklymak merged commit 4a23d21 into matplotlib:main Oct 24, 2021
@anntzer anntzer deleted the p3 branch October 24, 2021 16:51
@timhoffm
Copy link
Member

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 24, 2021
@jklymak @meeseeksmachine
Backport PR matplotlib#21446: Also exclude pyparsing 3.0.0 in setup.py.
6d70c8b
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 24, 2021
Merged
timhoffm added a commit that referenced this pull request Oct 24, 2021
@timhoffm
Merge pull request #21452 from meeseeksmachine/auto-backport-of-pr-21…
36162a4 
…446-on-v3.5.x

Backport PR #21446 on branch v3.5.x (Also exclude pyparsing 3.0.0 in setup.py.)
@mriedem
Copy link
mriedem commented Oct 25, 2021 •
edited
Loading

Any idea when this might get released? I'd like to avoid having to do the same cap on pyparsing in our project (which pulls in matplotlib as a transitive dependency, we don't require pyparsing directly) if we can just get it this way.

@tacaswell tacaswell added this to the v3.5.0 milestone Oct 25, 2021
@tacaswell
Copy link
Member

Hopefully this week, we have 1 blocking issue left for 3.5

@MalteKurz MalteKurz mentioned this pull request Oct 28, 2021
Closed
@timhoffm timhoffm mentioned this pull request Oct 28, 2021
Closed
@stsewd stsewd mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@anntzer @timhoffm @jklymak @dstansby @mriedem @tacaswell
0