8000 Enable Python 3.10 wheel building on all systems by QuLogic · Pull Request #21420 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Enable Python 3.10 wheel building on all systems #21420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2021
Merged

Enable Python 3.10 wheel building on all systems #21420

merged 1 commit into from
Oct 23, 2021

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Oct 21, 2021

PR Summary

NumPy now has wheels out for all our supported architectures.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Enable Python 3.10 wheel building on all systems
49a607d 
NumPy now has wheels out for all our supported architectures.
@QuLogic QuLogic added the Build label Oct 21, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Oct 21, 2021
@QuLogic
Copy link
Member Author
QuLogic commented Oct 22, 2021 •
edited
Loading

Test build appears to have worked. You can check the before_build steps for CPython 3.10 to see that NumPy wheels are being installed instead of compiled.

Though note that NumPy does not provide 32-bit Linux wheels, but that seems to have worked out for us now. If it does break, maybe we can consider dropping 32-bit Linux wheels.

@QuLogic QuLogic marked this pull request as ready for review October 22, 2021 02:01
@dstansby dstansby merged commit f4d83d0 into matplotlib:main Oct 23, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 23, 2021
@dstansby @meeseeksmachine
Backport PR matplotlib#21420: Enable Python 3.10 wheel building on al…
8ef676e 
…l systems
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 23, 2021
Merged
timhoffm added a commit that referenced this pull request Oct 23, 2021
@timhoffm
Merge pull request #21439 from meeseeksmachine/auto-backport-of-pr-21…
9781658 
…420-on-v3.5.x

Backport PR #21420 on branch v3.5.x (Enable Python 3.10 wheel building on all systems)
@QuLogic QuLogic deleted the enable-all-py310-wheels branch October 25, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @jklymak @dstansby
0