8000 Fix type1font docstring markup/punctuation. by anntzer · Pull Request #21343 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix type1font docstring markup/punctuation. #21343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix type1font docstring markup/punctuation. #21343

merged 1 commit into from
Oct 13, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 12, 2021

PR Summary

See misrendering currently at https://matplotlib.org/devdocs/api/type1font.html#matplotlib.type1font.Type1Font.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.5.1 milestone Oct 13, 2021
@jklymak jklymak merged commit 6cf17ba into matplotlib:master Oct 13, 2021
@lumberbot-app
Copy link
lumberbot-app bot commented Oct 13, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.5.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 6cf17ba46072e47a48d1a5c0d4a77e82ddc63af4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #21343: Fix type1font docstring markup/punctuation.'
  1. Push to a named branch :
git push YOURFORK v3.5.x:auto-backport-of-pr-21343-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR #21343 on branch v3.5.x (Fix type1font docstring markup/punctuation.)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@jklymak jklymak modified the milestones: v3.5.1, v3.6.0 Oct 13, 2021
@jklymak
Copy link
Member
jklymak commented Oct 13, 2021

Someone can feel free to back port if they wish...

@anntzer anntzer deleted the t1d branch October 13, 2021 06:42
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@jklymak
Merge pull request #21343 from anntzer/t1d
c2345f9 
Fix type1font docstring markup/punctuation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @QuLogic
0