Added linear scaling test to Hexbin marginals #21339
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Have changed snapping to default and updated the image |
|
If anyone merges this, please squash merge (or @j-bowhay you can rebase and squash the commits, and force push back here (make a back up branch first if you aren't used to doing this!)). This is particularly important to prevent the stray image from being in the repo. Thanks for your patience with the process!. |
|
lets move to draft until we sort out. @j-bowhay please ping us if the issue with hex bin does not get resolved soon. |
|
This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease # assuming you are tracking your branchIf you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
|
Hey @j-bowhay, are you still working in this PR? Because it is been inactive for a long time. Hope I am not disturbing you. |
|
Hi @LucasRicci this was blocked on #21349 by @timhoffm so I have not made the requested changes yet. I see there has been no progress on this issue yet. I am happy to finish the pr once the issue is fixed or if it is decided to add these test with the bug present and then update later. |
|
@j-bowhay Oh I see, thanks |
45e04ed to
1d12b60
Compare
Not blocked by #21349 anymore because, that turned out to be not a bug.
|
@j-bowhay thanks for the ping, and thanks for the PR! |
PR Summary
Added test for hexbin marginals that uses a linear scale. Closes #21165
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).