multiprocessing use should be optional during setup #2114
Conversation
| @@ -299,13 +299,27 @@ def run_2to3(self, files): | |||
| filtered = [x for x in files if should_2to3(x, self.build_lib)] | |||
| if sys.platform.startswith('win') or 'TRAVIS' in os.environ: | |||
There was a problem hiding this comment.
Do you remember why we need to do this for travis builds? Travis has may threads available to it and this would really benefit from being parallelised...
There was a problem hiding this comment.
Using multiprocessing on Travis was causing "Permission denied" errors -- but maybe it no longer does that, since clearly we're able to run our tests in parallel now.
Note, however, that this only applies to 1.2.x -- 1.3.x doesn't parallelize 2to3 because distribute is doing the 2to3 for us over there, and it doesn't support it -- it's most likely possible by overriding something or monkey-patching, but I haven't really spent any time looking into it.
There was a problem hiding this comment.
but I haven't really spent any time looking into it.
Ah. Don't worry about it. The tests (on v1.3.x) are now much quicker than they were.
multiprocessing use should be optional during setup
Some platforms don't support it.
It is used for
2to3conversion on1.2.x. It is used to determine theGtkversions on1.3.x. We should fix both problems.