Cleanup demo_tight_layout. #21100
Merged
Cleanup demo_tight_layout. #21100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove an extraneous plt.show() (the one at the end suffices). - This example has both pyplot and OO subexamples; if using pyplot, don't assign the `fig` name (better be fully implicit than stopping half-way); if using OO, use `fig.tight_layout()` instead of `plt.tight_layout()`. - Remove some blank lines.
timhoffm
approved these changes
Sep 16, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 16, 2021
QuLogic
reviewed
Sep 16, 2021
| example_plot(ax1) | ||
| example_plot(ax2) | ||
| example_plot(ax3) | ||
|
|
||
| plt.tight_layout() |
There was a problem hiding this comment.
I don't understand why you didn't change this (and all the rest) to fig.tight_layout instead of removing fig?
There was a problem hiding this comment.
Because the whole subexample is pyplot-based, and I didn't want to change that?
QuLogic
added a commit
that referenced
this pull request
Sep 17, 2021
…100-on-v3.5.x Backport PR #21100 on branch v3.5.x (Cleanup demo_tight_layout.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't assign the
figname (better be fully implicit than stoppinghalf-way); if using OO, use
fig.tight_layout()instead ofplt.tight_layout().PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).