8000 Support for forward/back mousebuttons on WX backend by Ptrskay3 · Pull Request #21044 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Support for forward/back mousebuttons on WX backend #21044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2021
Merged

Support for forward/back mousebuttons on WX backend #21044

merged 2 commits into from
Sep 11, 2021

Conversation

Ptrskay3
Copy link
Contributor
@Ptrskay3 Ptrskay3 commented Sep 11, 2021 •
edited
Loading

PR Summary

This PR adds the support for using the MouseButton.FORWARD and MouseButton.BACKWARD on the WX backend.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell
Copy link
Member

This seems reasonable to me.

Do we handle this in the other GUI toolkits already? If not would you be willing to add it to them as well (or atleast make issues to add them?)?

@Ptrskay3
Copy link
Contributor Author
Ptrskay3 commented Sep 11, 2021 •
edited
Loading

In Qt it's already in there. GTK3 also supports it, although I haven't verified that. AFAICT in Tk there is no built in way to detect the forward/back buttons. I haven't looked at other backends yet.

timhoffm
timhoffm reviewed Sep 11, 2021
View reviewed changes
@Ptrskay3 @timhoffm
Correct back/forward button assignment
cf6ab09 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@tacaswell tacaswell marked this pull request as ready for review September 11, 2021 20:04
@tacaswell tacaswell added this to the v3.5.0 milestone Sep 11, 2021
@timhoffm timhoffm merged commit 65cf35b into matplotlib:master Sep 11, 2021
@timhoffm
Copy link
Member

Thanks @Ptrskay3!

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 11, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21044: Support for forward/back mousebuttons o…
15b9fcf 
…n WX backend
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 11, 2021
Merged
timhoffm added a commit that referenced this pull request Sep 12, 2021
@timhoffm
Merge pull request #21048 from meeseeksmachine/auto-backport-of-pr-21…
2a3b7fa 
…044-on-v3.5.x

Backport PR #21044 on branch v3.5.x (Support for forward/back mousebuttons on WX backend)
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@timhoffm
Merge pull request #21044 from Ptrskay3/enable-history-wx
2ed19cf 
Support for forward/back mousebuttons on WX backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ptrskay3 @tacaswell @timhoffm
0