8000 Ensure full environment is passed to headless test. by QuLogic · Pull Request #20884 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Ensure full environment is passed to headless test. #20884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2021
Merged

Ensure full environment is passed to headless test. #20884

merged 1 commit into from
Aug 24, 2021

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Aug 24, 2021

PR Summary

Otherwise, e.g., PYTHONPATH is not available.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Ensure full environment is passed to headless test.
65dcc0e 
Otherwise, e.g., `PYTHONPATH` is not available.
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 24, 2021
anntzer
anntzer approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo ci

@timhoffm timhoffm merged commit 0f2ba37 into matplotlib:master Aug 24, 2021
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 24, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 24, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#20884: Ensure full environment is passed to he…
4bac8dc 
…adless test.
tacaswell added a commit that referenced this pull request Aug 24, 2021
@tacaswell
Merge pull request #20886 from meeseeksmachine/auto-backport-of-pr-20…
eb38299 
…884-on-v3.5.x

Backport PR #20884 on branch v3.5.x (Ensure full environment is passed to headless test.)
@QuLogic QuLogic deleted the headless-env branch August 24, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @timhoffm
0