8000 Fix ScalarFormatter.format_ticks for non-ordered tick locations. by anntzer · Pull Request #20542 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix ScalarFormatter.format_ticks for non-ordered tick locations. #20542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix ScalarFormatter.format_ticks for non-ordered tick locations. #20542

merged 1 commit into from
Jun 28, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 28, 2021

Non-ordered "ticks" locations can be used when using ScalarFormatter to
format contour lines. Perhaps ContourLabeler.get_text could arrange for
the "ticks" to be ordered, but it's much easier to just support
non-ordered ticks in ScalarFormatter.

Fixes partially #20529: the lowest contour is now correctly printed as 0.25, not 2.5. (The exponents are still missing, though.)

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Fix ScalarFormatter.format_ticks for non-ordered tick locations.
cc19764 
Non-ordered "ticks" locations can be used when using ScalarFormatter to
format contour lines.  Perhaps ContourLabeler.get_text could arrange for
the "ticks" to be ordered, but it's much easier to just support
non-ordered ticks in ScalarFormatter.
@story645 story645 merged commit 7585cd6 into matplotlib:master Jun 28, 2021
@anntzer anntzer deleted the sfft branch June 28, 2021 19:56
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 29, 2021
@dstansby dstansby mentioned this pull request Aug 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: ticks axis labels
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @QuLogic @story645
0