Cleanup AnchoredOffsetbox-related demos. #20493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11dee67 to
e650590
Compare
I have thought through if this is reasonable or not. However, we have these subclasses in
|
|
I think we should at least discourage their use: as always, I'd rather encourage people to compose APIs (eg put a TextArea in an AnchoredOffsetbox) rather than introducing new APIs for each combination (eg. AnchoredText). |
f818197 to
e20f7cc
Compare
timhoffm
reviewed
Jun 27, 2021
`userdemo/anchored_box0{1,2,3}` are basically subsets of
`misc/anchored_artists`. `anchored_box04` is slightly more
sophisticated; we may want to also merge it but in a later step.
In `anchored_artists`, no need to introduce new subclasses (whose
constructor need to support both the kwargs for AnchoredOffsetbox and
the kwargs for the child artist); it is simpler to just create an
AnchoredOffsetbox and set whatever child artist we want on it.
e20f7cc to
dfd6da1
Compare
timhoffm
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userdemo/anchored_box0{1,2,3}are basically subsets ofmisc/anchored_artists.anchored_box04is slightly moresophisticated; we may want to also merge it but in a later step.
In
anchored_artists, no need to introduce new subclasses (whoseconstructor need to support both the kwargs for AnchoredOffsetbox and
the kwargs for the child artist); it is simpler to just create an
AnchoredOffsetbox and set whatever child artist we want on it.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).