8000 Fix str of empty polygon. by anntzer · Pull Request #20480 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix str of empty polygon. #20480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix str of empty polygon. #20480

merged 1 commit into from
Jun 22, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 22, 2021

Previously vertices[0] would raise IndexError. This occurs e.g. with
cb = colorbar(); cb.patch which is an empty polygon.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Fix str of empty polygon.
1fb46d1 
Previously `vertices[0]` would raise IndexError.  This occurs e.g. with
`cb = colorbar(); cb.patch` which is an empty polygon.
@timhoffm timhoffm added this to the v3.4.3 milestone Jun 22, 2021
@timhoffm timhoffm merged commit 7f2288b into matplotlib:master Jun 22, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 22, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#20480: Fix str of empty polygon.
c7f2f42
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 22, 2021
Merged
@anntzer anntzer deleted the emptypolystr branch June 22, 2021 11:53
tacaswell added a commit that referenced this pull request Jun 22, 2021
@tacaswell
Merge pull request #20483 from meeseeksmachine/auto-backport-of-pr-20…
df9fa06 
…480-on-v3.4.x

Backport PR #20480 on branch v3.4.x (Fix str of empty polygon.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5F5D
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0