Various cleanups to pgf backend. #20466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 21, 2021
| # typeout width, height and text offset of the last textbox | ||
| self._stdin_writeln(r"\typeout{\the\wd0,\the\ht0,\the\dp0}") | ||
| # read answer from latex and advance to the next prompt | ||
| def _get_box_metrics(self, tex): |
There was a problem hiding this comment.
Should probably get a note that __init__ wraps this with a per-instance-cache.
QuLogic
approved these changes
Jun 22, 2021
- Replace _font_properties_str by _escape_and_apply_props, which handles all the preprocessing needed before sending a str to tex. (This means that LatexManager.get_text_width_height_descent now additionally handles unescaped strings as well, too.) - Replace str_cache by a (per-instance) lru_cache. - When querying tex for a string's metrics, send both `\sbox` and `\typeout` in a single go, which saves one cycle of waiting for the interactive prompt.
timhoffm
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all the preprocessing needed before sending a str to tex. (This means
that LatexManager.get_text_width_height_descent now additionally
handles unescaped strings as well, too.)
\sboxand\typeoutin a single go, which saves one cycle of waiting for theinteractive prompt.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).