8000 Fix dvi baseline detector when `\usepackage{chemformula}` is used. by anntzer · Pull Request #20442 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix dvi baseline detector when \usepackage{chemformula} is used. #20442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix dvi baseline detector when \usepackage{chemformula} is used. #20442

merged 1 commit into from
Jun 17, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 15, 2021

It's a bit a whack-a-mole, but heh...

Closes #20440.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic
QuLogic approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine, though it would be nice to have some alternate without the try-and-repeat updating.

@anntzer
Copy link
Contributor Author
anntzer commented Jun 17, 2021

I agree the whack-a-mole is not great, but I don't have a spec of how dvi is used "in practice" so it's hard for me to do anything other than try and observe what happens :(

@jklymak jklymak merged commit 3fc3b0d into matplotlib:master Jun 17, 2021 8000
@anntzer anntzer deleted the dvichemformula branch June 17, 2021 15:17
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: text/usetex
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Wrong text vertical position with LaTeX enabled
3 participants
@anntzer @QuLogic @jklymak
0