Add missing super __init__ in subclasses #20436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ones created by `_make_norm_from_scale` all call it.
These probably worked fine due to using `set_canvas_size` before `get_results`, or something that would set the remaining attributes.
The `vertices` and `codes` properties are overridden, so cannot be set directly, but the arrays that back them can be modified. This seems unintentional, so disable writing on those as well.
anntzer
reviewed
Jun 15, 2021
| @@ -385,11 +385,11 @@ def __init__(self, xy, s, size=None, prop=None, | |||
|
|
|||
| self._cached_vertices = None | |||
| s, ismath = Text(usetex=usetex)._preprocess_math(s) | |||
| self._vertices, self._codes = text_to_path.get_text_path( | |||
| prop, s, ismath=ismath) | |||
| super().__init__( | |||
There was a problem hiding this comment.
perhaps rather use fast_from_codes_and_verts for speed?
There was a problem hiding this comment.
That's a class method / constructor, though?
There was a problem hiding this comment.
ah yes. Oh well, I guess this isn't a bottleneck...
anntzer
approved these changes
Jun 15, 2021
jklymak
reviewed
Jun 15, 2021
| @@ -189,6 +189,7 @@ class MathtextBackendPs(MathtextBackend): | |||
| "_PSResult", "width height depth pswriter used_characters") | |||
|
|
|||
| def __init__(self): | |||
| super().__init__() | |||
There was a problem hiding this comment.
Are none of these really ever tested? Maybe beyond this PR, but they should be if they aren't...
There was a problem hiding this comment.
They're almost all unused, which I guess is why they're deprecated. For the ones that are used, I assume they all get .set_canvas_size called first, which sets the things that were missed in the super __init__.
tacaswell
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
These can cause issues for some static checks (I noticed them in LGTM), and mostly the code in the super
__init__is duplicated in the subclass.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).