8000 Deprecate public use of get_path_in_displaycoord. by anntzer · Pull Request #20428 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate public use of get_path_in_displaycoord. #20428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2021
Merged

Deprecate public use of get_path_in_displaycoord. #20428

merged 1 commit into from
Jun 14, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 13, 2021

It is a helper for FancyArrowPatch and ConnectionPatch, but no other
Artists expose such a method, while the normal approach is just to apply
get_transform() to get_path() (which is documented as an
alternative).

This may help future changes in the ArrowStyle API (e.g. allowing the
tip and the body to have different linestyles, #20385 (comment)).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Deprecate public use of get_path_in_displaycoord.
d3136e7 
It is a helper for FancyArrowPatch and ConnectionPatch, but no other
Artists expose such a method, while the normal approach is just to apply
`get_transform()` to `get_path()` (which is documented as an
alternative).

This may help future changes in the ArrowStyle API (e.g. allowing the
tip and the body to have different linestyles).
@timhoffm timhoffm added this to the v3.5.0 milestone Jun 14, 2021
@timhoffm timhoffm merged commit 91016d8 into matplotlib:master Jun 14, 2021
@anntzer anntzer deleted the gpid branch June 14, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: arrow
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

3AA3
3 participants
@anntzer @story645 @timhoffm
0