Merge arrow_simple_demo into arrow_guide. #20386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
approved these changes
Jun 8, 2021
story645
approved these changes
Jun 8, 2021
Comment on lines
118
to
119
| axs[1].arrow( | ||
| x_tail + 1, y_tail - .4, dx, dy, width=.1, length_includes_head=True) |
There was a problem hiding this comment.
I very much dig this example of showing how the patch is identical to the method.
QuLogic
reviewed
Jun 8, 2021
| axs[1].add_patch(arrow) | ||
| axs[1].arrow( | ||
| x_tail + 1, y_tail - .4, dx, dy, width=.1, length_includes_head=True) | ||
| axs[1].set(xlim=(0, 2), ylim=(0, 2)) |
There was a problem hiding this comment.
Should it be ymax=2? Seems to be a lot of whitespace in the bottom Axes compared to the top one.
There was a problem hiding this comment.
That's intentional to be consistent with the other figures created by this example and to show the distortion that occurs when drawing arrows in data coords.
timhoffm
reviewed
Jun 9, 2021
Comment on lines
107
to
111
| arrow = mpatches.FancyArrow( | ||
| x_tail, y_tail - .4, dx, dy, width=.1, length_includes_head=True) | ||
| axs[0].add_patch(arrow) | ||
| axs[0].arrow( | ||
| x_tail + 1, y_tail - .4, dx, dy, width=.1, length_includes_head=True) |
There was a problem hiding this comment.
Maybe color the arrows differently, so that it's easier to see which code created which arrow.
timhoffm
reviewed
Jun 9, 2021
| 8000 | width=.1, length_includes_head=True, color="C1") | |
| axs[0].add_patch(arrow) | ||
| axs[0].arrow(x_tail + 1, y_tail - .4, dx, dy, | ||
| width=.1, length_includes_head=True, color="C1") |
There was a problem hiding this comment.
Suggested change
| width=.1, length_includes_head=True, color="C1") | |
| width=.1, length_includes_head=True, color="C2") |
| width=.1, length_includes_head=True, color="C1") | ||
| axs[1].add_patch(arrow) | ||
| axs[1].arrow(x_tail + 1, y_tail - .4, dx, dy, | ||
| width=.1, length_includes_head=True, color="C1") |
There was a problem hiding this comment.
Suggested change
| width=.1, length_includes_head=True, color="C1") | |
| width=.1, length_includes_head=True, color="C2") |
plt.arrow() (aka patches.FancyArrow) has a rather awkward API and doesn't warrant its own demo, but can be mentioned at the end of the arrow guide together with patches.Arrow, which is nearly as awkward...
|
sure |
timhoffm
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plt.arrow() (aka patches.FancyArrow) has a rather awkward API (#12768) and
doesn't warrant its own demo, but can be mentioned at the end of the
arrow guide together with patches.Arrow, which is nearly as awkward...
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).