8000 Handle direction="column" in axes_grid.Grid by rgbmrc · Pull Request #20373 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Handle direction="column" in axes_grid.Grid #20373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2021
Merged

Handle direction="column" in axes_grid.Grid #20373

merged 4 commits into from
Jun 9, 2021

Conversation

rgbmrc
Copy link
Contributor
@rgbmrc rgbmrc commented Jun 5, 2021 •
edited
Loading

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@rgbmrc
Handle direction="column" in axes_grid.Grid
ea6121d 
- fixes matplotlib#20372
- uniformize docstring of Grid and ImageGrid
@jklymak
Copy link
Member
jklymak commented Jun 5, 2021

Thanks a lot for looking at this. Can it get a test?

github-actions[bot]
github-actions bot reviewed Jun 5, 2021
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@rgbmrc
Copy link
Contributor Author
rgbmrc commented Jun 5, 2021

Thanks a lot for looking at this. Can it get a test?

Seems reasonable. This (mini) PR and #20372 are my very first OSS contributions and I am not familiar with writing tests so I didn't include one but I will have a look at the developer guide and see what I can do.

@rgbmrc
Copy link
Contributor Author
rgbmrc commented Jun 7, 2021

A couple of tests for axes_grid.Grid are now included, checking

  • the axes_all, axes_row and axes_column relationship
  • the position of the axes in the grid, via locator

QuLogic
QuLogic reviewed Jun 7, 2021
View reviewed changes
@rgbmrc @QuLogic
parametrize test_grid_axes_position
98c1745 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@jklymak jklymak merged commit d7d50d9 into matplotlib:master Jun 9, 2021
@jklymak
Copy link
Member
jklymak commented Jun 9, 2021

Thanks a lot @rgbmrc!

(ooops, I should have squashed that first, my apologies).

@QuLogic QuLogic added this to the v3.5.0 milestone Jun 9, 2021
@rgbmrc rgbmrc deleted the patch-1 branch June 10, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Incorrect axes positioning in axes_grid.Grid with direction='column'
4 participants
@rgbmrc @jklymak @QuLogic @anntzer
0