8000 Fix possible refleak in PathGenerator. by anntzer · Pull Request #20347 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix possible refleak in PathGenerator. #20347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix possible refleak in PathGenerator. #20347

merged 1 commit into from
Jun 2, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 2, 2021

If one calls set() twice on the same PathGenerator, the first m_paths
needs to be decref'd. (We don't actually ever call set twice, I think,
but stil...)

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

8000
@anntzer
Fix possible refleak in PathGenerator.
4646515 
If one calls set() twice on the same PathGenerator, the first m_paths
needs to be decref'd.  (We don't actually ever call set twice, I think,
but stil...)
@WeatherGod
Copy link
Member

Good catch!

@timhoffm timhoffm merged commit a56da4a into matplotlib:master Jun 2, 2021
@anntzer anntzer deleted the pg branch June 2, 2021 19:31
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeatherGod WeatherGod WeatherGod approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @WeatherGod @timhoffm @QuLogic
0