8000 Fix cursor with toolmanager on GTK3. by QuLogic · Pull Request #20273 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix cursor with toolmanager on GTK3. #20273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2021
Merged

Fix cursor with toolmanager on GTK3. #20273

merged 1 commit into from
May 23, 2021

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented May 21, 2021

PR Summary

This was broken in #19441 because toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Fix cursor with toolmanager on GTK3.
fc17b2d 
This was broken in matplotlib#19441 because toolmanager uses a fake version of the
toolbar2 class which doesn't have any static (or otherwise) methods.
@QuLogic QuLogic added this to the v3.5.0 milestone May 21, 2021
@QuLogic
Copy link
Member Author
QuLogic commented May 21, 2021

I tried to add tests for this, but apparently #17986 makes this impossible.

@timhoffm
Copy link
Member

Merging without test. We can always add one if we find out how to.

@timhoffm timhoffm merged commit d56e1b4 914B into matplotlib:master May 23, 2021
@QuLogic QuLogic deleted the fix-toolmanager-gtk3 branch May 25, 2021 23:17
@anntzer anntzer mentioned this pull request Sep 3, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: gtk MEP: MEP22 tool manager topic: toolbar
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @timhoffm @anntzer
0