Simplify parameter handling in FloatingAxesBase. #20253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `grid_helper` can just become a standard kwonly arg. - `GridHelperCurveLinear` is the only class that defines `get_boundary`, so in practice the hasattr check is the same as an isinstance check. (It is technically possible that someone wrote their own GridHelperCurveLinear-like subclass with the same API, but let's not overly worry about that... and they can always still completely inherit GridHelperCurveLinear and full override everything if really needed.)
timhoffm
approved these changes
Oct 21, 2021
QuLogic
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_helpercan just become a standard kwonly arg.GridHelperCurveLinearis the only class that definesget_boundary,so in practice the hasattr check is the same as an isinstance check.
(It is technically possible that someone wrote their own
GridHelperCurveLinear-like subclass with the same API, but let's not
overly worry about that... and they can always still completely
inherit GridHelperCurveLinear and full override everything if really
needed.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).