8000 Add comments and format Axis._get_coord_info by Illviljan · Pull Request #20242 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Add comments and format Axis._get_coord_info #20242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2021

Conversation

Illviljan
Copy link
Contributor
@Illviljan Illviljan commented May 16, 2021

PR Summary

Explain Axis._get_coord_info better by adding comments and an (atleast to me) easier to read format. Should be no change in functionality.

Simplifies review of #19873 once merged.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (f 8000 ollow instructions in README.rst there).

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic merged commit 1f1eab9 into matplotlib:master May 18, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone May 18, 2021
@QuLogic
Copy link
Member
QuLogic commented May 18, 2021

Thanks @Illviljan! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0