Add a Ubuntu 20.04 / Python 3.9 CI run #20233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary on Ubuntu 20.04, which has Ghostscript 9.50.
|
Indeed, I've been ignoring those 3 failures locally! The updated PDFs look like the text is being clipped, is that expected? |
|
Do you mean on the left? That was always clipped. The difference is in the unicode line in the middle, which is shifted slightly. This probably happened long ago, and was fine with however older Ghostscript rasterized it before, but no longer. |
tacaswell
approved these changes
May 14, 2021
timhoffm
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This version has a new Ghostscript, so some baseline images needed an update. This is fine for me, since it fixes them on newer systems like Fedora, and likely Arch.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).