8000 Use check_getitem in legend location resolution. by anntzer · Pull Request #20211 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Use check_getitem in legend location resolution. #20211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

Use check_getitem in legend location resolution. #20211

merged 1 commit into from
May 12, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 12, 2021

... and remove a trailing dot in an exception message (consistently with
most of such messages).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Use check_getitem in legend location resolution.
855fe67 
... and remove a trailing dot in an exception message (consistently with
most of such messages).
@timhoffm timhoffm added this to the v3.5.0 milestone May 12, 2021
@timhoffm timhoffm merged commit 8034bc9 into matplotlib:master May 12, 2021
@anntzer anntzer deleted the lcg branch May 12, 2021 17:05
@anntzer anntzer mentioned this pull request Feb 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
4619 None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
0