8000 Fix broken link to ggplot in docs by akiomik · Pull Request #20145 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix broken link to ggplot in docs #20145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

akiomik
Copy link
Contributor
@akiomik akiomik commented May 3, 2021

PR Summary

Fixed the link to ggplot. The site has been moved from http://ggplot.yhathq.com to https://yhat.github.io/ggpy/.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

Thank you @akiomik ! Congratulations on your first merged Matplotlib PR 🎉 Hopefully we will hear from you again.

QuLogic added a commit that referenced this pull request May 4, 2021
…145-on-v3.4.1-doc

Backport PR #20145 on branch v3.4.1-doc (Fix broken link to ggplot in docs)
QuLogic added a commit that referenced this pull request May 4, 2021
…145-on-v3.4.x

Backport PR #20145 on branch v3.4.x (Fix broken link to ggplot in docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0