Remove some usages of OrderedDict #20078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Apr 25, 2021
anntzer
reviewed
Apr 26, 2021
... and simplify related code.
anntzer
approved these changes
Apr 26, 2021
|
(modulo ci) |
QuLogic
reviewed
Apr 26, 2021
| with style.context({PARAM: other_value}): | ||
| assert mpl.rcParams[PARAM] == other_value | ||
| x = style.context([d]) | ||
| x = style.context({PARAM: original_value, 'badparam': None}) |
There was a problem hiding this comment.
Do you need x, or can it just go in the with?
There was a problem hiding this comment.
I suppose this was written to check that the error occurs when entering the context, and not when creating it.
QuLogic
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and simplify related code.