8000 Copy-edit axes_grid tutorial. by anntzer · Pull Request #20074 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Copy-edit axes_grid tutorial. #20074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

Copy-edit axes_grid tutorial. #20074

merged 1 commit into from
May 1, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 25, 2021

Probably still needs further work (not in this PR), but hopefully an
improvement over the current state...

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak
jklymak reviewed Apr 25, 2021
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions. I think throughout we should try and point to main-library equivalents when they exist.

@anntzer
Copy link
Contributor Author
anntzer commented Apr 26, 2021

Thanks. Agree with referring to the main lib where possible.

QuLogic
QuLogic reviewed Apr 30, 2021
View reviewed changes
@anntzer
Copy-edit axes_grid tutorial.
ef26f4a 
Probab
8000
ly still needs further work (not in this PR), but hopefully an
improvement over the current state...
@anntzer
Copy link
Contributor Author
anntzer commented Apr 30, 2021

thanks, edited.

@QuLogic QuLogic merged commit 319f24f into matplotlib:master May 1, 2021
@anntzer anntzer deleted the dag branch May 1, 2021 08:24
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak left review comments

Assignees
No one assigned
Labels
Documentation topic: mpl_toolkit
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @jklymak
0