8000 Deprecate AxesDivider.append_axes(..., add_to_figure=True). by anntzer · Pull Request #20065 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate AxesDivider.append_axes(..., add_to_figure=True). #20065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

Deprecate AxesDivider.append_axes(..., add_to_figure=True). #20065

merged 1 commit into from
Apr 25, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 24, 2021

This was never ever used in the git history, has a simple alternative,
and is consistent with 3b4d7c4 which removed the similar add_all from
other axes_grid APIs.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Deprecate AxesDivider.append_axes(..., add_to_figure=True).
6b94dcf 
This was never ever used in the git history, has a simple alternative,
and is consistent with 3b4d7c4 which removed the similar `add_all` from
other axes_grid APIs.
@anntzer anntzer added this to the v3.5.0 milestone Apr 24, 2021
@dstansby dstansby merged commit a08e334 into matplotlib:master Apr 25, 2021
@anntzer anntzer deleted the atf branch April 25, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby
0