8000 Cleanup widget examples by timhoffm · Pull Request #20031 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@timhoffm
Copy link
Member

PR Summary

  • don't use 90ish background color. The default style is good enough (actually better IMHO).
  • In the span selector:
    • '-' is the default style. We don't need to specify it explicitly.
    • It's more logical that the bottom "selected region" plot is empty at the beginning, when nothing has been selected so far.
    • Use blue as a selection color (Nicer appearance IMHO)
    • Some variable renaming.

@timhoffm timhoffm added this to the v3.4.2 milestone Apr 20, 2021
@QuLogic QuLogic merged commit 45031fd into matplotlib:master Apr 21, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 21, 2021
@timhoffm timhoffm deleted the doc-widget-style branch April 21, 2021 06:20
timhoffm added a commit that referenced this pull request Apr 21, 2021
…031-on-v3.4.x

Backport PR #20031 on branch v3.4.x (Cleanup widget examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0