Fix axvspan for drawing slices on polar plots. #20027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already special-casing for polar plots in bar() (using the same `_interpolation_steps = 100`); it seems reasonable to use the same approach for axvspan (e.g. `polar(); axvspan(0, pi/4)`). It seems like making axhspan work (basically drawing full rings) is less easy, but there's an easy enough workaround (`polar(); bar(0, bottom=1, height=1, width=2*pi)`) as the "x" (theta) extent is actually known in that case.
timhoffm
approved these changes
Apr 20, 2021
QuLogic
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already special-casing for polar plots in bar() (using the same
_interpolation_steps = 100); it seems reasonable to use the sameapproach for axvspan (e.g.
polar(); axvspan(0, pi/4)).It seems like making axhspan work (basically drawing full rings) is less
easy, but there's an easy enough workaround
(
polar(); bar(0, bottom=1, height=1, width=2*pi)) as the "x" (theta)extent is actually known in that case.
plt.polar(); plt.axvspan(np.pi/4, np.pi/2)before:
after:
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).