Bump minimum NumPy to 1.17 #20003

QuLogic · 2021-04-16T23:29:58Z

PR Summary

Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (run flake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs should build without error).
Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
[n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

dstansby · 2021-04-17T10:06:18Z

It looks like the python38-min doc build failure might be real due to a numpy installation issue. I've restarted it to see if it fails again.

dstansby · 2021-04-17T10:17:53Z

Still failing, so I'm guessing we might want to bump to something between 1.17.1 and 1.17.5

QuLogic · 2021-04-19T21:21:56Z

Yes, the oldest NumPy 1.17 with Python 3.8 wheels is 1.17.3.

QuLogic added the Maintenance label Apr 16, 2021

QuLogic added this to the v3.5.0 milestone Apr 16, 2021

QuLogic force-pushed the np117 branch from 73d36d9 to 717f7b5 Compare April 17, 2021 00:06

jklymak approved these changes Apr 17, 2021

View reviewed changes

Bump minimum NumPy to 1.17.

aa500f5

QuLogic force-pushed the np117 branch from 717f7b5 to aa500f5 Compare April 19, 2021 21:21

jkseppan approved these changes May 1, 2021

View reviewed changes

jkseppan merged commit d7c70bb into matplotlib:master May 1, 2021

QuLogic deleted the np117 branch May 3, 2021 19:51