8000 Added a TextBox widget by keflavich · Pull Request #1983 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Added a TextBox widget #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Added a TextBox widget #1983

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
487c15a
added TextBox Widget
keflavich May 7, 2013
557adaa
lazy cursor
Jun 4, 2013
4110887
rename (de)activate, remove inconsistent active properties
Jun 4, 2013
82e3f9b
remove unused self.region
Jun 4, 2013
8ed729b
inherit/use AxesWidget
Jun 4, 2013
19fd160
cleanup __init__
Jun 4, 2013
dc4b04c
actually inherit from AxesWidget
Jun 4, 2013
32d9bb0
rely on default Text properties
Jun 4, 2013
dc8ef76
docs
Jun 4, 2013
003c931
ignore callbacks when active=False
Jun 4, 2013
e77e5e5
fix spelling of _get_text_right
Jun 4, 2013
952e122
fix spelling mouse_activate, ignore when apropriate
Jun 4, 2013
e307788
remove unused vars
Jun 4, 2013
a83b096
tab todo
Jun 4, 2013
c11973c
spell _mouse_activate correctly
Jun 4, 2013
1a2a1aa
Merge pull request #1 from mrterry/textboxwidget
keflavich Jun 4, 2013
5239d7e
spelling and formatting
Jun 5, 2013
f523505
drop float-specific formatting rules
Jun 5, 2013
42b8489
remove redraw option from set_text
Jun 5, 2013
d80083b
drop more float-specific logic
Jun 5, 2013
4b963a5
TextBox produces str values
Jun 5, 2013
aba387a
convenience function for producing TextBoxes with float values
Jun 5, 2013
a1e0207
use on_changed() convention. use drawon, too
Jun 10, 2013
a81e0b8
TextBoxFloat is a class
Jun 10, 2013
8f753d0
spelling
Jun 10, 2013
b382ceb
Merge pull request #2 from mrterry/textboxwidget
keflavich Jun 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spelling and formatting
  • Loading branch information
Matt Terry committed Jun 5, 2013
commit 5239d7e162da232429cf49d68bea6177599a52dc
33 changes: 18 additions & 15 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,8 +1672,8 @@ def __init__(self, ax, s='', enter_callback=None, **text_kwargs):
activate the cursor.

*WARNING* Activating a textbox will remove all other key-press
bindings! They'll be stored in FloatTextBox.old_callbacks and restored
when FloatTextBox.end_text_entry() is called.
bindings! They'll be stored in TextBox.old_callbacks and restored
when TextBox.end_text_entry() is called.

The default widget assumes only numerical data and will not
allow text entry besides numerical characters and ('e','-','.')
Expand All @@ -1684,15 +1684,15 @@ def __init__(self, ax, s='', enter_callback=None, **text_kwargs):
The parent axes for the widget

*s* : str
The initial text of the FloatTextBox. Should be able to be coerced
The initial text of the TextBox. Should be able to be coerced
to a float.

*enter_callback* : function
A function of one argument that will be called with
FloatTextBox.value passed in as the only argument when enter is
A function of one argument that will be called with
TextBox.value passed in as the only argument when enter is
pressed

*text_kwargs* :
*text_kwargs* :
Additional keywork arguments are passed on to self.ax.text()
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I'm not familiar with the numpydoc format but we should conform to that for the sake of consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in my branch.

AxesWidget.__init__(self, ax)
Expand All @@ -1701,8 +1701,8 @@ def __init__(self, ax, s='', enter_callback=None, **text_kwargs):
self.ax.set_xticks([])

self.value = float(s)
self.text = self.ax.text(0.025, 0.2, s, transform=self.ax.transAxes,
**text_kwargs)
self.text = self.ax.text(0.025, 0.2, s,
transform=self.ax.transAxes, **text_kwargs)

self.enter_callback = enter_callback
self._cid = None
Expand All @@ -1719,8 +1719,10 @@ def cursor(self):
# solve some of the problems associated
if self._cursor is None:
r = self._get_text_right() # needs a renderer
self._cursor, = self.ax.plot([r,r], [0.2, 0.8],
transform=self.ax.transAxes)
self._cursor = self.ax.plot([r, r],
[0.2, 0.8],
transform=self.ax.transAxes,
)[0]
self._cursor.set_visible(False)
return self._cursor

Expand All @@ -1745,7 +1747,8 @@ def begin_text_entry(self):
for k in keypress_cbs.keys():
self.old_callbacks[k] = keypress_cbs.pop(k)

self._cid = self.canvas.mpl_connect('key_press_event', self.keypress)
self._cid = self.canvas.mpl_connect('key_press_event',
self.keypress)
self.cursor.set_visible(True)
self.redraw()

Expand Down Expand Up @@ -1816,7 +1819,7 @@ def keypress(self, event):
self.set_text(newt, redraw=True)

r = self._get_text_right()
self.cursor.set_xdata([r,r])
self.cursor.set_xdata([r, r])
self.redraw()

def set_text(self, text, redraw=False):
Expand All @@ -1836,11 +1839,11 @@ def set_text(self, text, redraw=False):

def _get_text_right(self):
bbox = self.text.get_window_extent()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This get_window_extent() causes problems on MacOSX. (related to the blitting problems with macosx). You can get around it by calling self.canvas.draw() before get_window_extent(), but that can be laggy. If you check the backend, you can only inflict the lag on macosx users. But then you're putting backend checks into supposedly backend independent widgets.

Any less hacky ideas of how to get the rendered width of a block of text?

l,b,w,h = bbox.bounds
l, b, w, h = bbox.bounds

renderer = self.ax.get_renderer_cache()
en = renderer.points_to_pixels(self.text.get_fontsize()) / 2.

r = l + self._cursorpos*np.ceil(en)
r,t = self.ax.transAxes.inverted().transform((r,b+h))
r = l + self._cursorpos * np.ceil(en)
r, t = self.ax.transAxes.inverted().transform((r, b + h))
return r
0