8000 Factor out machinery for running subprocess tk tests. by anntzer · Pull Request #19825 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Factor out machinery for running subprocess tk tests. #19825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2021
Merged

Factor out machinery for running subprocess tk tests. #19825

merged 1 commit into from
Apr 5, 2021

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 30, 2021

Probably it can also be shared with test_interactive_backends in the
future.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

timhoffm
timhoffm reviewed Mar 30, 2021
View reviewed changes
@anntzer anntzer force-pushed the tkt branch 2 times, most recently from 1aed444 to 3fe72be Compare March 30, 2021 22:36
@anntzer anntzer force-pushed the tkt branch 2 times, most recently from 47a5a61 to 094f4ca Compare March 31, 2021 08:39
QuLogic
QuLogic reviewed Apr 1, 2021
View reviewed changes
@anntzer
Factor out machinery for running subprocess tk tests.
d60a7ad 
Probably it can also be shared with test_interactive_backends in the
future.
@QuLogic QuLogic added this to the v3.5.0 milestone Apr 5, 2021
@QuLogic QuLogic merged commit 10a0e82 into matplotlib:master Apr 5, 2021
@anntzer anntzer deleted the tkt branch April 5, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk Maintenance topic: testing
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0