E5ED Move svg basename detection down to RendererSVG. by anntzer · Pull Request #19495 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Move svg basename detection down to RendererSVG. #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 1 commit into from
Jul 8, 2021
Merged

Move svg basename detection down to RendererSVG. #19495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/matplotlib/backends/backend_svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,13 @@ def __init__(self, width, height, svgwriter, basename=None, image_dpi=72,
self.writer = XMLWriter(svgwriter)
self.image_dpi = image_dpi # actual dpi at which we rasterize stuff

self._groupd = {}
if basename is None:
basename = getattr(svgwriter, "name", "")
if not isinstance(basename, str):
basename = ""
self.basename = basename

self._groupd = {}
self._image_counter = itertools.count()
self._clipd = {}
self._markers = {}
Expand Down Expand Up @@ -1311,9 +1316,6 @@ def print_svg(self, filename, *args, **kwargs):
__ DC_
"""
with cbook.open_file_cm(filename, "w", encoding="utf-8") as fh:
filename = getattr(fh, 'name', '')
if not isinstance(filename, str):
filename = ''
if not cbook.file_requires_unicode(fh):
fh = codecs.getwriter('utf-8')(fh)
self._print_svg(filename, fh, **kwargs)
Expand All @@ -1336,7 +1338,7 @@ def _print_svg(self, filename, fh, *, dpi=None, bbox_inches_restore=None,

renderer = MixedModeRenderer(
self.figure, width, height, dpi,
RendererSVG(w, h, fh, filename, dpi, metadata=metadata),
RendererSVG(w, h, fh, image_dpi=dpi, metadata=metadata),
bbox_inches_restore=bbox_inches_restore)

self.figure.draw(renderer)
Expand Down
0