10000 fixes TypeError constructor returned NULL in wayland session by liuyun88 · Pull Request #19416 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

fixes TypeError constructor returned NULL in wayland session #19416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

fixes TypeError constructor returned NULL in wayland session #19416

merged 1 commit into from
Feb 2, 2021

Conversation

liuyun88
Copy link
Contributor
@liuyun88 liuyun88 commented Feb 1, 2021

PR Summary

fixes #19405. updated GTK3 method for cursor control for GTK3 backend. fixes the TypeError constructor returned NULL error that prevents pyplot to run under Wayland.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

github-actions[bot]
github-actions bot reviewed Feb 1, 2021
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

Thanks @liuyun88 !

The failures look real and due to a mix of tabs and spaces in the patch. We only use (4) spaces in the mpl code base.

@liuyun88
fixes #19405. allows pyplot to run under Wayland using GTK3 backend, …
3d50004 
…by using the updated GTK3 method for cursor control.
@liuyun88
Copy link
Contributor Author
liuyun88 commented Feb 1, 2021

Thanks for pointing it out. I think I have corrected the tab/space error.

Had a hard time syncing between the upstream, fork and local changes. Hopefully did not introduce any undesired changes.

8000

@QuLogic QuLogic added this to the v3.4.0 milestone Feb 2, 2021
@anntzer
Copy link
Contributor
anntzer commented Feb 2, 2021

thanks for the PR, we hope to see you again soon :)

@anntzer anntzer merged commit b93f563 into matplotlib:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
GUI: gtk
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

TypeError constructor returned NULL in wayland session
4 participants
@liuyun88 @tacaswell @anntzer @QuLogic
0