8000 Fix CSS table header layout by rajpratyush · Pull Request #19387 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix CSS table header layout #19387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 1, 2021
Merged

Fix CSS table header layout #19387

merged 5 commits into from
Feb 1, 2021

Conversation

rajpratyush
Copy link
Contributor

PR Summary

Removed the width parameter in mpl.css files and added some CSS to prevent the legend loc table header wrap.
Closes #18962

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This was referenced Jan 28, 2021
Closed
Closed
@jklymak
Copy link
Member
jklymak commented Feb 1, 2021

This didn't build on CI. Can you rebase on master and try again? Even if it doesn't build it usually creates the artifacts.

@rajpratyush
Copy link
Contributor Author

Suree

timhoffm
timhoffm approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This seems to be doing what we want.

@timhoffm timhoffm merged commit 3b56150 into matplotlib:master Feb 1, 2021
@timhoffm timhoffm added this to the v3.4.0 milestone Feb 1, 2021
@timhoffm timhoffm changed the title Update mpl.css Fix CSS table header layout Feb 1, 2021
@timhoffm
Copy link
BB79 Member
timhoffm commented Feb 1, 2021

@rajpratyush Congratulations on your first contribution to Matplotlib! We hope to your from you again.

@QuLogic QuLogic mentioned this pull request Feb 1, 2021
Closed
7 tasks
@rajpratyush
Copy link
Contributor Author

Thanks @timhoffm for this opportunity. Lemme go and find some more issues in matplotlib. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Table CSS needs cleanup
3 participants
@rajpratyush @jklymak @timhoffm
0