8000 DOC: contributor incubator by tacaswell · Pull Request #19125 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

DOC: contributor incubator #19125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

DOC: contributor incubator #19125

merged 1 commit into from
Dec 16, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

Adds prose to docs about the "incubator" (nee #tidepool) discussed on the call.

The purpose of this channel is that, operating on the theory than the hardest PR to a project is the first, is to provide some mentoring / support to people who want to become regular contributors but do not know where to start.

The other issue I think we have in the user -> first PR -> multiple PR -> reviewer pipeline as that we can not tell who of our first time contributors wants to become a regular contributor and who is doing a drive-by PR to scratch their itch. This is a path where we are asking people to self-identify as wanting to be come regular contributors.

@tacaswell tacaswell added this to the v3.4.0 milestone Dec 16, 2020
jklymak
jklymak approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, so long as that channel exists ;-)

@tacaswell
Copy link
Member Author

I was holding off creating the channel until after we had merged this.

@jklymak jklymak merged commit a02ffbc into matplotlib:master Dec 16, 2020
@tacaswell tacaswell deleted the doc_incubator branch 8000 December 16, 2020 21:41
@timhoffm
Copy link
Member

No offense meant, but I find the first two sentences rather intimidating. Listing reasons why one could be intimidated is counter-productive. I'd just do something like:

If you are interested in becoming a regular contributor to Matplotlib, but don't know where to start or feel insecure about it, you can join our non-public communication channel for new contributors. To do so, please go to gitter and ask to be added to '#incubator'. [original text from here on] This is a private gitter room moderated by core Matplotlib developers where you can get guidance and support for your first few PRs. This is a place you can ask questions about anything: how to use git, github, how our PR review process works, technical questions about the code, or get "pre-review" on your PR.

@QuLogic
Copy link
Member
QuLogic commented Dec 17, 2020

I agree with this; giving a number to it (10M / month) is even more intimidating.

@jklymak
Copy link
Member
jklymak commented Dec 17, 2020

I also agree. Just wanted to get the thing rolling, but I don't think a PR with @timhoffm wording would be at all remiss.

story645 added a commit to story645/matplotlib that referenced this pull request Dec 17, 2020
@story645
Following up on Incubator docs
73dafa3 
Completely stole @timhoffm 's language & added a bit about help w/ non-code ways of contributing.  follow up to matplotlib#19125
This was referenced Dec 17, 2020
Merged
Merged
story645 added a commit that referenced this pull request Dec 17, 2020
@story645
Following up on Incubator docs
04deb33 
Completely stole @timhoffm 's language & added a bit about help w/ non-code ways of contributing.  follow up to #19125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @timhoffm @QuLogic @jklymak
0