10000 Support setting rcParams["image.cmap"] to Colormap instances. by anntzer · Pull Request #19106 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Support setting rcParams["image.cmap"] to Colormap instances. #19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Support setting rcParams["image.cmap"] to Colormap instances. #19106

merged 1 commit into from
Dec 15, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 13, 2020

This makes it possible to set the rcParam to a non-registered colormap
(which cannot be referred to by name). A use-case is to set it to e.g.
viridis.with_extremes(bad="k").

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Support setting rcParams["image.cmap"] to Colormap instances.
bb2de5e 
This makes it possible to set the rcParam to a non-registered colormap
(which cannot be referred to by name).  A use-case is to set it to e.g.
`viridis.with_extremes(bad="k")`.
@anntzer anntzer added this to the v3.4.0 milestone Dec 13, 2020
dopplershift
dopplershift approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's up with the test failure.

@QuLogic
Copy link
Member
QuLogic commented Dec 15, 2020

That was fixed earlier today.

@QuLogic QuLogic closed this Dec 15, 2020
@QuLogic QuLogic reopened this Dec 15, 2020
@jklymak jklymak merged commit 93649f8 into matplotlib:master Dec 15, 2020
@anntzer anntzer deleted the image.cmap=colormap branch December 15, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: color/color & colormaps topic: rcparams
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @dopplershift @jklymak
0