The Artist property rasterized cannot be None anymore #18989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now a bool only. Before the default was non and `Artist.set_rasterized` documented to accept *None*. However, *None* did not have a special meaning and was treated as *False.
dopplershift
approved these changes
Nov 21, 2020
tacaswell
approved these changes
Nov 21, 2020
tacaswell
reviewed
Nov 21, 2020
|
@timhoffm I took the liberty of fixing the rst typo. |
timhoffm
commented
Nov 22, 2020
|
Please squash-merge after CI pass. |
jklymak
reviewed
Nov 22, 2020
| @@ -0,0 +1,5 @@ | |||
| The Artist property *rasterized* cannot be *None* anymore | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| It is now a bool only. Before the default was non and `.Artist.set_rasterized` | |||
There was a problem hiding this comment.
Suggested change
| It is now a bool only. Before the default was non and `.Artist.set_rasterized` | |
| It is now a bool only. Before the default was *None* and `.Artist.set_rasterized` |
There was a problem hiding this comment.
We only use None as a default, if that default is not a simple data type (e.g. depends on rcParams or is an object; e.g. a Norm). If the default is a bool like here, we use that directly.
There was a problem hiding this comment.
Woops. I was so distracted by your confusion 😃. Corrected in #18996.
7 tasks
|
Self-merged based on 2 positive reviews. |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Nov 23, 2020
- Use correct issue number in filename - Fix typo `non` -> `None`
jklymak
added a commit
that referenced
this pull request
Nov 23, 2020
Fix API change message from #18989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It is now a bool only. Before the default was None and
Artist.set_rasterizeddocumented to accept None. However, Nonedid not have a special meaning and was treated as False.
This is:
set_rasterizedto accept None. However as with most bools, we just check the truthiness, so None is further accepted implicitly.get_rasterized() is Nonebecause None has no special meaning.Because of the above I dare go without deprecation.