Cleanup Firefox SVG example. #18981
Merged
Cleanup Firefox SVG example. #18981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
approved these changes
Nov 20, 2020
QuLogic
reviewed
Nov 20, 2020
In the SVG parser: simplify the regexes; do not drop "z" codes (they were previously dropped because they are immediately followed by another code, and thus did not match `path_re`; things only worked because the SVG source was careful to explicitly move back to the start point before issuing CLOSEPOLYs) but instead include them explicitly. Don't rely on later in-place modification of `verts` propagating back to `path`, but modify it first. Make the figure background gray (as was the case for the classic style); that makes the white outline visible again (otherwise that white outline doesn't really make sense). Also just generally compress the rest of the code down.
timhoffm
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SVG parser: simplify the regexes; do not drop "z" codes (they
were previously dropped because they are immediately followed by another
code, and thus did not match
path_re; things only worked because theSVG source was careful to explicitly move back to the start point before
issuing CLOSEPOLYs) but instead include them explicitly.
Don't rely on later in-place modification of
vertspropagating back topath, but modify it first.Make the figure background gray (as was the case for the classic style);
that makes the white outline visible again (otherwise that white outline
doesn't really make sense). Also just generally compress the rest of
the code down.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).