8000 Small cleanup to StepPatch._update_path. by anntzer · Pull Request #18943 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Small cleanup to StepPatch._update_path. #18943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2020
Merged

Small cleanup to StepPatch._update_path. #18943

merged 1 commit into from
Nov 14, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 13, 2020
  • No need to explicitly convert to arrays in codes; concatenate
    will do that for us.
  • We only need to compute the Path once at the end of the loop
    (all other iterations are just thrown away).
  • Both verts and codes are being concatenated along their
    first axis, so using different stackers (vstack/hstack) just
    hides that symmetry.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer
Small cleanup to StepPatch._update_path.
a6f119f 
- No need to explicitly convert to arrays in `codes`; `concatenate`
  will do that for us.
- We only need to compute the Path once at the end of the loop
  (all other iterations are just thrown away).
- Both `verts` and `codes` are being concatenated along their
  first axis, so using different stackers (`vstack`/`hstack`) just
  hides that symmetry.
@anntzer anntzer mentioned this pull request Nov 13, 2020
Closed
@timhoffm timhoffm added this to the v3.4.0 milestone Nov 14, 2020
@timhoffm timhoffm merged commit 38f20a3 into matplotlib:master Nov 14, 2020
@anntzer anntzer deleted the sp branch November 14, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0