10000 Remove "Demo" from example titles by timhoffm · Pull Request #18858 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Remove "Demo" from example titles #18858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Nov 1, 2020

PR Summary

In the context of example titles "Demo" is a fill word without meaning. All examples are demos.

This PR removes some usages of "Demo". If possible, the title is changed to something more meaningful. (Which is also the reason, I'm only doing part of the examples. Good titles need a bit of thought for every single case).

@story645
Copy link
Member
story645 commented Nov 1, 2020

Not sure why all the doc builds decided to fail 😕 (otherwise would merge)

@timhoffm
Copy link
Member Author
timhoffm commented Nov 1, 2020

Docs fixed.

For info: This was failing:

/home/circleci/project/doc/gallery/axes_grid1/demo_axes_rgb.rst:16: WARNING: more than one target found for cross-reference 'RGBAxes': mpl_toolkits.axes_grid1.axes_rgb.RGBAxes, mpl_toolkits.axisartist.axes_rgb.RGBAxes

As a general rule, if you want to find out, what made the doc builds fail:

  1. Click on the failed build (e.g. docs-python38)
  2. Download the full log.
  3. Search case-sensitive for "WARNING" in the full log.

95% of the time that shows you why sphinx was unhappy.

@jklymak jklymak merged commit 2ca5ed1 into matplotlib:master Nov 1, 2020
@timhoffm timhoffm deleted the remove-demo branch November 1, 2020 21:54
@timhoffm timhoffm added this to the v3.4.0 milestone Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0