Make inset indicator more visible in the example #18795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The full on black inset lines is maybe not optimal aesthetic choice, but I think it elevates the example's raison d'être of helping people learn via the examples. |
story645
approved these changes
Oct 23, 2020
|
Nice. Also sort of think it might be good if you could make the connecting lines dashed, but that leads to an API change since right now the args are only passed through to the rectangle, so way out of scope of this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds an
edgecolor='black'to the inset indicator in the example.I learned how to do this earlier today and actually didn't realize from the example that there was already an inset indicator because I didn't notice it on account of it being so faint against the background. So I ended up googling something and then fond the api of
indicate_inset. I think with this change I would have done all my learning from this example.original:
this pr:
Ancillary suggestion: Change the default value of
edgecolorsfrom'0.5'to'gray'matplotlib/lib/matplotlib/axes/_axes.py
Lines 355 to 357 in db6206d
I actually didn't know you could specify colors like this in matplotlib and then got very confused when I got an error when I changed it
0.7(w/o quotes) 🐑PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).