8000 Turn "How to use Matplotlib in a web application server" into a sphinx-gallery example by Transfusion · Pull Request #18767 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Turn "How to use Matplotlib in a web application server" into a sphinx-gallery example #18767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2020
Merged

Turn "How to use Matplotlib in a web application server" into a sphinx-gallery example #18767

merged 3 commits into from
Oct 20, 2020

Conversation

Transfusion
Copy link
Contributor
@Transfusion Transfusion commented Oct 18, 2020 •
edited
Loading

PR Summary

Fixes #18301 by removing the "How to use Matplotlib in a web application server" section from howto_faq.rst and turning it into a "Embedding Matplotlib in graphical user interfaces" sphinx-gallery example.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffm timhoffm mentioned this pull request Oct 19, 2020
Closed
@QuLogic
Copy link
Member
QuLogic commented Oct 20, 2020

This probably needs a note about how to run it. If you haven't used Flask before, you might run it directly, and then it does nothing.

From the same directory, you can do FLASK_APP=web_application_server_sgskip flask run which would work.

@QuLogic QuLogic added this to the v3.4.0 milestone Oct 20, 2020
@QuLogic QuLogic merged commit d872350 into matplotlib:master Oct 20, 2020
@QuLogic
Copy link
Member
QuLogic commented Oct 20, 2020

Thanks @Transfusion! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@timhoffm timhoffm mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

"How to use Matplotlib in a web application server" should be made an example
2 participants
@Transfusion @QuLogic
0