Remove the use_cmex font fallback mechanism. #18721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 13, 2020
lib/matplotlib/_mathtext.py
Outdated
| @@ -452,7 +451,7 @@ class UnicodeFonts(TruetypeFonts): | |||
| This class will "fallback" on the Bakoma fonts when a required | |||
| symbol can not be found in the font. | |||
| """ | |||
| use_cmex = True | |||
| use_cmex = True # Deprecated. | |||
There was a problem hiding this comment.
I think this is more helpful for us in the future:
Suggested change
| use_cmex = True # Deprecated. | |
| use_cmex = True # Unused. Delete once matplotlib.mathtext is private. |
Same comment should be used below as well.
|
It's not gone, fallback still works (as long as you have |
The `use_cmex` flag and `latex_to_cmex` table is a fallback-to-computermodern mathtext system that is strictly less powerful than the `mathtext.fallback_to_cm` (now `mathtext.fallback`) system. Also, the `latex_to_cmex` table was incomplete. Previously, with something like ``` rcParams["mathtext.fontset"] = "custom"; figtext(.5, .5, r"$\leftangle\langle$") ``` `\leftangle` would get unconditionally replaced by a Computer Modern glyph, whereas `\langle` would stay as DejaVu Sans (as DejaVu provides that glyph). With this patch, both glyphs now use DejaVu. Conversely, if one forces the use of a font which does not contain the `\langle` glyph (e.g. adding `rcParams["mathtext.rm"] = "Comic Sans MS"`), then both `\leftangle` and `\langle` get substituted to use Computer Modern; this is not changed by this PR (except that now *both* fallbacks can be controlled by `rcParams["mathtext.fallback"]`. `latex_to_cmex` and `use_cmex` were marked as deprecated, but with no actual deprecation machinery as they can all go away once `mathtext` fully goes private anyways.
7e7c5ab to
b1691d9
Compare
timhoffm
approved these changes
Oct 13, 2020
dopplershift
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
use_cmexflag andlatex_to_cmextable is afallback-to-computermodern mathtext system that is strictly less
powerful than the
mathtext.fallback_to_cm(nowmathtext.fallback)system. Also, the
latex_to_cmextable was incomplete.Previously, with something like
\leftanglewould get unconditionally replaced by a Computer Modernglyph, whereas
\langlewould stay as DejaVu Sans (as DejaVu providesthat glyph). With this patch, both glyphs now use DejaVu.
Conversely, if one forces the use of a font which does not contain the
\langleglyph (e.g. addingrcParams["mathtext.rm"] = "Comic Sans MS"), then both\leftangleand\langleget substituted to useComputer Modern; this is not changed by this PR (except that now both
fallbacks can be controlled by
rcParams["mathtext.fallback"].latex_to_cmexanduse_cmexwere marked as deprecated, but with noactual deprecation machinery as they can all go away once
mathtextfully goes private anyways.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).