8000 Cleanup pgf examples by QuLogic · Pull Request #18685 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Cleanup pgf examples #18685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Cleanup pgf examples #18685

merged 2 commits into from
Oct 8, 2020

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented Oct 7, 2020

PR Summary

Switch from pyplot to OO style, and swap a font selector so that it doesn't warn as much.

PR Checklist

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Comment on lines +11 to +12
# Use LaTeX default serif font.
"font.serif": [],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this fallback does not work for me; it decides to use 'DejaVu Sans' before even getting to pgf/LaTeX. I'm not sure how to fix it.

This enables using a known specific font for sans directly, and a group
of fonts for fallback in the comic sans case.
@timhoffm timhoffm merged commit efa0ece into matplotlib:master Oct 8, 2020
@QuLogic QuLogic deleted the pgf-examples branch October 8, 2020 20:08
@QuLogic QuLogic added this to the v3.4.0 milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0