8000 Small API cleanups to plot_directive. by anntzer · Pull Request #18682 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Small API cleanups to plot_directive. #18682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Small API cleanups to plot_directive. #18682

merged 1 commit into from
Oct 8, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 7, 2020

docutils' Image.align has existed since 2006.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added this to the v3.4.0 milestone Oct 7, 2020
QuLogic
QuLogic approved these changes Oct 7, 2020
View reviewed changes
doc/api/next_api_changes/deprecations/X-AL.rst Outdated
@@ -0,0 +1,4 @@
``sphinext.plot_directive.align``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@anntzer
Small API cleanups to plot_directive.
7a199a2 
docutils' Image.align has existed since 2006.
@timhoffm timhoffm merged commit 3e9efe7 into matplotlib:master Oct 8, 2020
@anntzer anntzer deleted the pd branch October 8, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: sphinx extension
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0