-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Legend shadow color #18668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Legend shadow color #18668
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e29e69e
Remove unused/deprecated AVConv_ classes
Tranquilled c492987
Remove references to removed classes from docs
Tranquilled 5fcb7d8
Add explicit shadowcolor flag to legend; default to previous behavior
Tranquilled 2c97d51
Revert "Remove unused/deprecated AVConv_ classes"
Tranquilled ea20273
Revert "Remove references to removed classes from docs"
Tranquilled f6a929c
Remove shadowcolor flag; allow color values for shadow flag
Tranquilled 7c5d798
Add test, remove stray space
Tranquilled e13ee8d
Change error message and add a test for it
Tranquilled fe09612
Return a more accurate error from color/bool validation
Tranquilled 3f2a000
Add documentation
Tranquilled 6300971
Attempt to fix documentation
Tranquilled 69d8d6f
Remove third option
Tranquilled fca7f20
Attempt to resolve error
Tranquilled f2a0d39
Merge master
Tranquilled 4cf4266
Remove call to draw canvas
Tranquilled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Shadow parameter for Legend can be colorlike or bool | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The parameter can now be any colorlike in addition to | ||
a bool. If it is neither, a ValueError is thrown. | ||
|
||
An accessory validation function `~.rcsetup.validate_color_or_bool` | ||
has also been added, which preferentially returns a color. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Legend shadow colors can be explicitly defined | ||
---------------------------------------------- | ||
|
||
The shadow parameter for the Legend constructor now | ||
Tranquilled marked this conversation as resolved.
Show resolved
Hide resolved
|
||
accepts both color and bool. If it is a bool, the | ||
behavior is exactly the same as before. | ||
Any colorlike value sets the shadow to that color, | ||
subject to the same transparency effect that the default | ||
facecolor undergoes. | ||
|
||
An accessory validation function `~.rcsetup.validate_color_or_bool` | ||
has also been added, which preferentially returns a color. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.